Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support named tuples, nested tuples and type aliases #128

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Support named tuples, nested tuples and type aliases #128

merged 8 commits into from
Jun 27, 2022

Conversation

taco-paco
Copy link
Contributor

@taco-paco taco-paco commented Jun 24, 2022 •
edited by FabijanC
Loading

Usage related changes

Development related changes

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

@FabijanC FabijanC self-requested a review June 24, 2022 09:34
FabijanC
FabijanC requested changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you first do something about the formatting changes? I see the same pattern as in your previous plugin PR.

FabijanC
FabijanC requested changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just had some smaller observations.

src/adapt.ts Show resolved Hide resolved
src/adapt.ts Outdated Show resolved Hide resolved
src/adapt.ts Outdated Show resolved Hide resolved
src/adapt.ts Outdated Show resolved Hide resolved
@FabijanC FabijanC self-requested a review June 27, 2022 10:59
@FabijanC FabijanC changed the title Named tuples Support named tuples, nested tuples and type aliases Jun 27, 2022
@FabijanC FabijanC merged commit ca6b259 into master Jun 27, 2022
@FabijanC FabijanC deleted the namedTuples branch June 27, 2022 11:03
@pscott pscott mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Type Alias
2 participants
@taco-paco @FabijanC