Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to devnet & integrated-devnet requests #274

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Add timeout to devnet & integrated-devnet requests #274

merged 2 commits into from
Dec 14, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Dec 13, 2022 •
edited by FabijanC
Loading

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL
Add timeout to devnet & integrated-devnet requests
038e6a2 
- Have 30 seconds as a request timeout
@Nathan-SL Nathan-SL requested a review from FabijanC December 13, 2022 15:43
FabijanC
FabijanC requested changes Dec 13, 2022
View reviewed changes
src/devnet-utils.ts Outdated Show resolved Hide resolved
src/devnet-utils.ts Outdated Show resolved Hide resolved
src/devnet-utils.ts Outdated Show resolved Hide resolved
src/devnet-utils.ts Outdated Show resolved Hide resolved
@Nathan-SL
Update devnet-utils
cad87ed 
- Set axiosInstance private
- Remove headers from requestHandler
- Set generic type T parameter for requestHandler
@FabijanC FabijanC merged commit bac6115 into master Dec 14, 2022
@FabijanC FabijanC deleted the request-timeout branch December 14, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timeout to starknet.devnet requests
2 participants
@Nathan-SL @FabijanC