Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

286 type defs #291

Merged
merged 6 commits into from
Jan 9, 2023
Merged

286 type defs #291

merged 6 commits into from
Jan 9, 2023

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Jan 4, 2023

Usage related changes

None

Development related changes

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
    • If src/type-extensions.ts was changed, updated the line number referencing this file in the ## API section of README.md ⚠️ Won't need this ever again 🥳
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC self-requested a review January 9, 2023 09:37
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did not completely check if all the lines in the old files match the ones in the new files, but generally looks great!

@FabijanC FabijanC merged commit 70cabca into 0xSpaceShard:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move starknet and devnet type definitions to dedicated files
2 participants