Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-dev npm script for easier per-test testing #343

Merged
merged 17 commits into from
Apr 28, 2023

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Apr 21, 2023

Usage related changes

N/A

Development related changes

Resolves #290

New script test-dev, designed to run same test repeatedly while developing.

$ npm run test-dev

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@shramee
Copy link
Contributor Author

shramee commented Apr 21, 2023

Hi guys!

Getting this error atm,

1) Class declaration
should declare using declare v2 and interact with the class:
StarknetPluginError: Could not perform call on getPublicKey.
Got BadRequest while trying to access https://alpha4.starknet.io/feeder_gateway/call_contract?blockNumber=pending. Status code: 500; text: {"code": "StarknetErrorCode.UNINITIALIZED_CONTRACT", "message": "Requested contract address 0x347be35996a21f6bf0623e75dbce52baba918ad5ae8d83b6f416045ab22961a is not deployed."}

Needs some investigation 🔍

Now resolved and ready 🔥

@FabijanC FabijanC self-requested a review April 21, 2023 07:14
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are several indentation inconsistencies (space vs tab) and files not terminated with a newline. Could be addressed by simply forcing a format in your editor (e.g. ctrl+shift+i in vscode).

scripts/test.sh Outdated Show resolved Hide resolved
scripts/test.sh Outdated Show resolved Hide resolved
scripts/run-devnet.sh Outdated Show resolved Hide resolved
scripts/test-dev.sh Outdated Show resolved Hide resolved
scripts/devnet-run.sh Outdated Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
scripts/test-setup.sh Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
scripts/test-dev.sh Outdated Show resolved Hide resolved
scripts/test-dev.sh Outdated Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
scripts/test-dev.sh Outdated Show resolved Hide resolved
scripts/devnet-stop.sh Outdated Show resolved Hide resolved
scripts/devnet-run.sh Outdated Show resolved Hide resolved
scripts/test-dev.sh Show resolved Hide resolved
@shramee shramee requested a review from FabijanC April 28, 2023 11:18
@FabijanC FabijanC changed the title 290 tests v3 Add test-dev npm script for easier per-test testing Apr 28, 2023
@FabijanC FabijanC merged commit 9b7bae9 into 0xSpaceShard:master Apr 28, 2023
@shramee shramee mentioned this pull request Apr 28, 2023
11 tasks
@VeryDustyBot
Copy link

This item belongs to payment request #8BC743 on OnlyDust:

@VeryDustyBot
Copy link

This item belongs to payment request #436E02 on OnlyDust:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make running tests easier
3 participants