-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler downloader #402
Compiler downloader #402
Conversation
- Allow download by specifying version - Refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work for compiling files outside of the repo? Was this case supported with older compiler?
- import config.json on top of file
- Update method name - Update return type - Ensure exact compilerVersion is installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs conflict resolution. There are still three unresolved conversations, I marked the others as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to make GitHub stop indicating that changes are requested. Assigning another reviewer.
Usage related changes
compilerVersion
is specified in the hardhat config file, this is used. These two options cannot be specified at the same time (there is a runtime check). If the user doesn't specify any, the last compiler version compatible with the plugin is used.~/.starknet-hardhat-plugin
. If already present here (and executable), we use that.Development related changes
assertCompilationArtifactsExist
starknet-wrapper.ts
, the compilation functions are moved to the abstract parent class (StarknetWrapper
)Checklist:
test
directory (with a test case consisting ofnetwork.json
,hardhat.config.ts
,check.ts
)plugin
branch ofstarknet-hardhat-example
:Compiler downloader starknet-hardhat-example#120