Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Base, BNB, Cosmos icons #2

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

DominicF96
Copy link
Collaborator

@DominicF96 DominicF96 commented Apr 2, 2024

Hello !

Added BASE, BNB and COSMOS icons.
Please let me know if I can help with the changes needed to integrate chain icons.

Thanks again for this project 🚀

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
token-icons ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 7:41pm

@0xa3k5
Copy link
Owner

0xa3k5 commented Apr 2, 2024

hey, @DominicF96 thank you so much for your contribution! To support the network icons, I need to do some structural changes -- which I'm currently working on. I'll hold this PR open for a bit, and will merge it as soon as I got those changes done (I'm hoping I'll make it ready within a day)

# Conflicts:
#	packages/core/src/raw-svgs/tokens/branded/BASE.svg
#	packages/core/src/raw-svgs/tokens/branded/BNB.svg
#	packages/core/src/raw-svgs/tokens/branded/COSMOS.svg
#	packages/core/src/raw-svgs/tokens/mono/BASE.svg
#	packages/core/src/raw-svgs/tokens/mono/BNB.svg
#	packages/core/src/raw-svgs/tokens/mono/COSMOS.svg
@0xa3k5
Copy link
Owner

0xa3k5 commented Apr 4, 2024

hey @DominicF96 I've made the necessary changes to start supporting NetworkIcons. That introduced a bunch of new things and actually opened up the ways to expand even more, maybe WalletIcons, DappIcons, ProtocolIcons..

Looks like I will be spending some more time on this project 😅

I've pulled new changes to your PR and we should be able to merge this. But please do check out the README.md and the new CONTRIBUTING.md I've included some guides for how to make the icons.

You can use the new component in your project. Thank you again, for your contribution -- greatly appreciated.

@0xa3k5 0xa3k5 merged commit 3397492 into 0xa3k5:main Apr 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants