Merge pull request #56 from 0xabu/typed_pdfminer

Use new pdfminer release, with type annotations
0xabu · Mar 19, 2022 · 29780ef · 29780ef
2 parents 0e68261 + 05e90fd
commit 29780ef
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 18 deletions.
diff --git a/mypy.ini b/mypy.ini
@@ -14,17 +14,3 @@ warn_unused_ignores = True
 warn_return_any = True
 no_implicit_reexport = True
 strict_equality = True
-
-[mypy-pdfannots.*]
-# temporary, for https://github.com/pdfminer/pdfminer.six/pull/661
-warn_unused_ignores = False
-
-[mypy-pdfminer.*]
-ignore_missing_imports = True
-disallow_untyped_calls = False
-disallow_untyped_defs = False
-check_untyped_defs = False
-warn_unused_ignores = False
-
-[mypy-cryptography.hazmat.*]
-ignore_missing_imports = True
diff --git a/pdfannots/__init__.py b/pdfannots/__init__.py
@@ -216,8 +216,7 @@ def walk_number_tree(td: typing.Dict[typing.Any, typing.Any]
  yield prefix + label
 
 
-class _PDFProcessor(PDFLayoutAnalyzer): # type:ignore
- # (pdfminer lacks type annotations)
+class _PDFProcessor(PDFLayoutAnalyzer):
  """
  PDF processor class.
 

diff --git a/pdfannots/types.py b/pdfannots/types.py
@@ -196,7 +196,7 @@ def __lt__(self, other: typing.Any) -> bool:
 
  def item_hit(self, item: LTComponent) -> bool:
  """Is this pos within the bounding box of the given PDF component?"""
- return (self.x >= item.x0 # type: ignore [no-any-return]
+ return (self.x >= item.x0
  and self.x <= item.x1
  and self.y >= item.y0
  and self.y <= item.y1)

diff --git a/requirements.txt b/requirements.txt
@@ -1,4 +1,4 @@
 # pip requirements for pdfannots
 # Use as: pip3 install -r requirements.txt
 
-pdfminer.six == 20201018
+pdfminer.six == 20220319