Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal setup.py file #35

Merged
merged 1 commit into from
Mar 31, 2021
Merged

add minimal setup.py file #35

merged 1 commit into from
Mar 31, 2021

Conversation

karlicoss
Copy link
Contributor

Will this be welcome? :)
This allows installing the package as: pip install 'git+https://path/to/repo.git', so it's easier to use as a library

this allows installing the package as: pip install 'git+https://path/to/repo.git'
@0xabu 0xabu merged commit 608d896 into 0xabu:master Mar 31, 2021
@0xabu
Copy link
Owner

0xabu commented Mar 31, 2021

Sure. I don't see myself using this, but I've no objection to taking it. Thanks.

Out of curiosity, are you planning to use it that way? It's not really ideal in that form yet.

@karlicoss
Copy link
Contributor Author

karlicoss commented Mar 31, 2021

Thanks! I'm using it in HPI which is sort of a central hub for all my personal data.
So for instance I can import my.pdfs and have all files/annotations readily available. This patch would allow to run hpi module install my.pdfs to install the dependencies, useful for quick setup/CI/etc.

One way I'm using it is to periodically (runs in cron) generate a list (in org-mode) of all pdfs/annotations on my filesystem via an orger module. That way it's easy to overview all annotated documents and search in all annotations. Was about to prettify it a bit to also allow jumping directly to file/page.

Yeah, it's not 100% perfect as a library, but with a couple of hacks works well enough!

There is also a custom patch for extracting date for Annotation class I forgot to cleanup & push, I'm happy to open a PR for it along with a test -- would you accept it?

@0xabu
Copy link
Owner

0xabu commented Mar 31, 2021

There is also a custom patch for extracting date for Annotation class I forgot to cleanup & push, I'm happy to open a PR for it along with a test -- would you accept it?

Most likely, yes, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants