Handle "Square" annotations, but don't attempt to capture text #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue #46, Apple tools support "highlighting" PDFs where the hightlights are emitted as a Square annotation with a custom appearance that renders the markup. Figuring out the affected text would be a major undertaking, but with this change we (1) recognise the existence of the annotation rather than emitting an "unsupported annotation" warning, and (2) capture the contents (text note) of the annotation if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #46, Apple tools support "highlighting" PDFs where the hightlights
are emitted as a Square annotation with a custom appearance that renders the
markup. Figuring out the affected text would be a major undertaking, but
with this change we (1) recognise the existence of the annotation rather than
emitting an "unsupported annotation" warning, and (2) capture the contents
(text note) of the annotation if any.