Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --page-number-offset to change page numbers #90

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

gvtulder
Copy link
Contributor

@gvtulder gvtulder commented Feb 5, 2024

This option can be used to add or subtract a fixed number from the printed page numbers. This is useful if, for example, the document includes a cover page and the page numbers of the PDF do not match the page numbers of the document.

Example: --page-number-offset -1 renumbers page 1 to 0 in the Markdown output.

Copy link
Owner

@0xabu 0xabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean PR! I just have a couple of ultra-minor nits, and the format nagger may have others.

pdfannots/cli.py Outdated Show resolved Hide resolved
pdfannots/printer/markdown.py Outdated Show resolved Hide resolved
pdfannots/types.py Show resolved Hide resolved
@gvtulder gvtulder force-pushed the f-page-number-offset branch 2 times, most recently from 3ab1962 to 6aec786 Compare February 5, 2024 11:40
@gvtulder
Copy link
Contributor Author

gvtulder commented Feb 5, 2024

Thanks, I've pushed a new version with those small changes.

This option can be used to add or subtract a fixed number from the
printed page numbers. This is useful if, for example, the document
includes a cover page and the page numbers of the PDF do not match the
page numbers of the document.
@gvtulder
Copy link
Contributor Author

gvtulder commented Feb 5, 2024

flake8 and autopep8 should pass now.

@0xabu 0xabu merged commit 054dfa9 into 0xabu:main Feb 5, 2024
8 checks passed
@gvtulder gvtulder deleted the f-page-number-offset branch February 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants