Skip to content

feat: Segmented axis#41

Merged
0xb-s merged 31 commits intomainfrom
segmented_line
Nov 6, 2025
Merged

feat: Segmented axis#41
0xb-s merged 31 commits intomainfrom
segmented_line

Conversation

@0xb-s
Copy link
Owner

@0xb-s 0xb-s commented Nov 3, 2025

No description provided.

Copy link
Collaborator

@michalsustr michalsustr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up issues

if x < 200.0 {
(x * 0.05).sin() * 5.0 + 10.0
} else if x < 800.0 {
12.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More natural would be to keep it undefined for the gaps and use the Line::new_xy_blocks

@michalsustr michalsustr changed the title feat: Segmented line feat: Segmented axis Nov 3, 2025
@0xb-s 0xb-s requested a review from michalsustr November 5, 2025 13:32
let approx_steps = (span / step_hint.max(f64::EPSILON)).max(1.0);
let raw_step = span / approx_steps;

let nice = nice_step(raw_step);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in this PR, it's a simple change

@0xb-s 0xb-s requested a review from michalsustr November 6, 2025 11:12
@0xb-s 0xb-s merged commit ed128b8 into main Nov 6, 2025
5 of 7 checks passed
@0xb-s 0xb-s deleted the segmented_line branch November 6, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants