Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 governed contracts for whitelisting cw721 contracts and ICS721 channels. #1

Closed
wants to merge 53 commits into from

Conversation

taitruong
Copy link

@taitruong taitruong commented Mar 22, 2023

4 governed proxy implementations for ICS721 usage:

  1. cw721-code-id-proxy
  2. cw721-sender-proxy
  3. ics721-channel-proxy
  4. ics721-sender-channels-proxy

These can then be used by ICS721 here:
https://github.com/public-awesome/ics721/blob/main/contracts/cw-ics721-bridge/src/msg.rs#L18-L22
https://github.com/public-awesome/ics721/blob/main/contracts/cw-ics721-bridge/src/contract.rs#L431

@taitruong
Copy link
Author

PR contains now 2 contracts: contracts/cw721-sender-whitelist-proxy and contracts/ics721-channel-whitelist-proxy. 2 thoughts on this:

  1. both contracts are from a functional point of view. maybe there is a better approach of merging both into a more generic wl proxy.
  2. another contract icw721-sender-and-channel-whitelist-proxy would be great. Also here: maybe there is a better (rule-based?) solution than just doing copy-pasta.

@taitruong taitruong changed the title A governed cw721/sender whitelist proxy. 2 governed contracts for whitelisting cw721/sender and ICS721 channels. Mar 22, 2023
@0xekez 0xekez self-requested a review March 29, 2023 08:10
@taitruong taitruong closed this Jul 5, 2023
@taitruong taitruong deleted the sender-whitelist branch January 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant