Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed hyphen #1

Merged
merged 1 commit into from
Apr 30, 2019
Merged

fixed hyphen #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- **Fix `publish` and `preview` bug for projects with a `-` - [jaysonsantos], [issue/36] [pull/38]**

Rust is a sometimes surprisingly opinionated language! When your `Cargo.toml` specifies a project
name with a hypen(`-`) in the name, the Rust compiler will implicitly understand this as a `_` for
name with a hyphen(`-`) in the name, the Rust compiler will implicitly understand this as a `_` for
all imports and when it creates compiled artifacts it will name them with a `_`.

The original implementation of `wrangler` skipped over this, and as a result would go looking for a
Expand Down