Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: speedup re-compilation with flags #400

Merged
merged 2 commits into from
Jul 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: ./.github/actions/rust

- name: Run tests
run: cargo test --locked --all-targets --release
run: cargo test --locked --all-targets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since now you have custom profile test don't you need to use --profile test in the command ? like https://stackoverflow.com/questions/41920192/does-cargo-support-custom-profiles
or test command has its own builtin test profile ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


cargo-clippy:
if: github.event.pull_request.draft == false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
uses: ./.github/actions/rust

- name: Run tests
run: cargo test --locked --all-targets --release
run: cargo test --locked --all-targets

- name: Create github issue for failed action
uses: imjohnbo/issue-bot@v3
Expand Down
7 changes: 6 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,15 @@ members = [
"circuits",
]

[profile.release]
[profile.test]
# Full list of settings: https://doc.rust-lang.org/cargo/reference/profiles.html#release
inherits = "release"
# We are running our tests in release mode to make them faster.
# But we want to catch overflow errors, so we enable overflow checks here for now:
overflow-checks = true
# This is false by default in the 'release' profile but we want
# better re-compilation times here
incremental = true

[patch.crates-io]
plonky2_field = { git = "https://github.com/0xmozak/plonky2.git" }
Expand Down