Swaps #1138
Swaps #1138
Conversation
Move send swaps code to send repo
| return ( | ||
| <> | ||
| <Head> | ||
| <title>Send | Swap Form</title> |
There was a problem hiding this comment.
No need for Form in the title
|
|
||
| const CHAIN = 'base' | ||
| const SWAP_FEE = '75' // 0.75% feeAmount is the percentage of fees that we will take with base unit = 10000 | ||
| const KYBER_NATIVE_TOKEN_ADDRESS = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE' |
| } | ||
|
|
||
| const { | ||
| data: { routeSummary, routerAddress }, |
There was a problem hiding this comment.
Should create a zod schema
| }), | ||
| }).then((res) => res.json())) as KyberEncodeRouteResponse | ||
|
|
||
| if (response.code !== 0) { |
There was a problem hiding this comment.
Is this code from kybers API?
| throw new Error(response.message) | ||
| } | ||
|
|
||
| return response.data |
There was a problem hiding this comment.
Another place to consider a zod schema
|
Vercel Unique URL: https://sendapp-kq3xwekkf-0xsend.vercel.app |
Playwright ReportSummary
Suitesaccount-rewards.onboarded.spec.tscan visit rewards page
account-sendtag-add.onboarded.spec.tscan visit add sendtags page
can add a pending tag
cannot add an invalid tag name
cannot add more than 5 tags
cannot confirm a tag without paying
account-sendtag-checkout.onboarded.spec.tscan confirm a tag
can refer a tag
can refer multiple tags in separate transactions
account-settings-backup.onboarded.spec.tscan backup account
can remove a signer
account.logged-in.spec.tscan visit account page
can update profile
activity.onboarded.spec.tscan visit activity page and see correct activity feed
can search on activity page
home.onboarded.spec.tscan visit token detail page
Expected: �[33m/home/runner/_work/sendapp/sendapp/packages/playwright/tests/home.onboarded.spec.ts-snapshots/token-details-history-url-chromium�[39m �[0m �[90m 28 |�[39m status�[33m:�[39m �[35m200�[39m�[33m,�[39m
Expected: �[33m/home/runner/_work/sendapp/sendapp/packages/playwright/tests/home.onboarded.spec.ts-snapshots/token-details-history-url-firefox�[39m �[0m �[90m 28 |�[39m status�[33m:�[39m �[35m200�[39m�[33m,�[39m leaderboard.logged-in.spec.tscan visit leaderboard page
onboarding.logged-in.spec.tscan visit onboarding page
profile.anon.spec.tsanon user can visit public profile
anon user cannot visit private profile
profile.logged-in.spec.tslogged in user needs onboarding before visiting profile
profile.onboarded.spec.tscan visit other user profile and send by tag
can visit my own profile
can visit private profile
can view activities between another profile
send-token-upgrade.onboarded.spec.tscan upgrade their Send Token V0 to Send Token V1
send.onboarded.spec.tscan send USDC starting from profile page
can send USDC using tag starting from home page
can send USDC using sendid starting from home page
can send USDC using address starting from home page
can send ETH starting from profile page
can send ETH using tag starting from home page
can send ETH using sendid starting from home page
can send ETH using address starting from home page
can send SEND starting from profile page
can send SEND using tag starting from home page
can send SEND using sendid starting from home page
can send SEND using address starting from home page
sign-in.anon.spec.tsredirect on sign-in
redirect to send confirm page on sign-in
sign-up.anon.spec.tscan sign up
country code is selected based on geoip
skip otp for existing user trying to sign up using already used phone number
user can sign in with passkey from backing up page
user can sign in as back up using otp from backing up page
|
There was a problem hiding this comment.
Should be a screen. Also, we need more logic here I just realized. If the user has 0 swaps (hopefully we can check that using the activity feed), we need to show an agreement modal. Hopefully Ethen can get us a quick disclaimer and checkbox agreement soon.
No description provided.