Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed and magic signatures guide #292

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moskalyk
Copy link
Contributor

No description provided.

@moskalyk
Copy link
Contributor Author

work in progress awaiting feedback

Copy link
Contributor

@ScreamingHawk ScreamingHawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.
I'm not a wordsmith so worth someone else having a look to ensure the message is clear and polished.


# Verified Typed Data & Validated Signature Messages On-chain

Time to complete: XX minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XX

docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
docs/pages/guides/typed-on-chain-signatures.mdx Outdated Show resolved Hide resolved
@JamesLawton
Copy link
Collaborator

This looks really interesting, however my understanding is that we have APIs that abstract some of this complexity away. Is this providing a different use case in some way or is there a reason we want to show this at the smart contract level that our current API is not meeting?

Would like to understand better as my concern is our user base will likely prefer to simply use the APIs for sig and typed data verification given the overhead, i.e., what use cases does this enable vs our API? @moskalyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants