-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating getDefaultConfig method #98
Conversation
8b44e4a
to
9dbf75d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But I think we can delete the commented code.
2bfc8b6
to
a01e277
Compare
a01e277
to
c019d92
Compare
0db1a11
to
fc57e77
Compare
maybe we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
This provides a new method
getDefaultConfig
and a wrapping component that takes this configSequenceKit
getDefaultConfig(walletType: 'waas' | 'universal', config: CombinedWaasConfig | CombinedUniversalConfig)
This method takes 2 params, the first specifies the wallet type (waas or universal) and the second is a combined config object which allows you to specify KitConfig as well as Connector options for the specific wallet type. You can also pass in any additional wagmi options with the
wagmiConfig
prop