Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percentage calculator #303

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

percentage calculator #303

wants to merge 5 commits into from

Conversation

aman-7299
Copy link

@aman-7299 aman-7299 commented May 11, 2022 •
edited
Loading

Description 📜

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # <issue_number_here>

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GSSOC'22 contributor
  • Have you added a working video of your calculator ?

Screenshots / Gif (Optional) 📸

@awesome-bot-app
Copy link


Thanks for opening the pull request @aman-7299! I will look into it ASAP!
Till then you can improve your code & you can show your love by staring my repos 😋.

@aman-7299
Copy link
Author

here i m changing in index file

mansi-garg-12
mansi-garg-12 requested changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do mention the changes which you have done

@mansi-garg-12 mansi-garg-12 added changes Changes Requested and removed review_needed labels May 11, 2022
@aman-7299
Copy link
Author

Please do mention the changes which you have done

I just index.html file of binary search

mansi-garg-12
mansi-garg-12 reviewed May 12, 2022
View reviewed changes
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasu-1 please check this one.....

@0xvashishth
Copy link
Owner

@aman-7299 Specify the issue number

image

0xvashishth
0xvashishth requested changes May 28, 2022
View reviewed changes
Copy link
Owner

@0xvashishth 0xvashishth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script.js file has been unlinked !Not giving output !
Fix this ! @aman-7299

0xvashishth
0xvashishth requested changes May 28, 2022
View reviewed changes
Copy link
Owner

@0xvashishth 0xvashishth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name of pull accordingly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansi-garg-12 mansi-garg-12 mansi-garg-12 requested changes

@0xvashishth 0xvashishth 0xvashishth requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes Changes Requested GSSoC22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-7299 @0xvashishth @mansi-garg-12