Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(1499) - Replace to eleventy-plugin-sass package as it's deprecated #1500

Merged
merged 1 commit into from
Mar 28, 2022
Merged

chore(1499) - Replace to eleventy-plugin-sass package as it's deprecated #1500

merged 1 commit into from
Mar 28, 2022

Conversation

hybridx
Copy link
Contributor

@hybridx hybridx commented Mar 25, 2022 •
edited
Loading

Closes/Fixes/Resolves

Resolves #1499

Explain the feature/fix

  • Removed eleventy-sass dependency

Does this PR introduce a breaking change

  • No

Screenshots

View Screenshots Screenshot 2022-03-25 at 7 52 57 PM

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demoed and the design review approved?

@hybridx hybridx added bug Something isn't working chore Internal things, technical debt, and to-do tasks to be performed. labels Mar 25, 2022
@hybridx hybridx self-assigned this Mar 25, 2022
@hybridx hybridx marked this pull request as ready for review March 25, 2022 14:24
@hybridx hybridx requested review from deshmukhmayur and mudit94 and removed request for ghanlohar, deshmukhmayur and mudit94 March 28, 2022 09:54
@hybridx hybridx marked this pull request as draft March 28, 2022 09:56
@hybridx hybridx marked this pull request as ready for review March 28, 2022 09:57
@deshmukhmayur
Copy link
Member

@hybridx The SASS compilation should be done inside the .eleventy.js file. Can you send a separate PR for that later?

@deshmukhmayur deshmukhmayur merged commit 4a9ee83 into 1-Platform:master Mar 28, 2022
@hybridx
Copy link
Contributor Author

hybridx commented Mar 28, 2022

@hybridx The SASS compilation should be done inside the .eleventy.js file. Can you send a separate PR for that later?

@deshmukhmayur Created an issue for this #1505

@hybridx hybridx deleted the chore/1499 branch September 1, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilmhdh akhilmhdh akhilmhdh approved these changes

@deshmukhmayur deshmukhmayur deshmukhmayur approved these changes

@mudit94 mudit94 mudit94 approved these changes

Assignees

@hybridx hybridx

Labels
bug Something isn't working chore Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace to eleventy-plugin-sass package as it's deprecated
4 participants
@hybridx @deshmukhmayur @mudit94 @akhilmhdh