Submitting comments from Monday's (4/5) review! #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added my initial thoughts to the PR comment! Overall, working in the back-end is starting to click, which is a good feeling when it looked like witchcraft just a few weeks ago. |
|
... I don't think I was supposed to close the PR with my comment 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting out the code and trying to explain what each line did was a great and positive learning experience! It really helped connect the dots to the different lines of code that are starting to live in different files. I think this would be a good learning technique to adopt as other YouTube instructors also upload their working files in GitHub repos like this!
On another note, I'm unfortunately still running into issues with Heroku when trying to deploy my personal code for the todo list. It looks like the issue revolves around my get request and heroku timing out and prompting me with an error code h12. However, I'm not giving up and still working through it!