Skip to content

Commit

Permalink
Fix #123 : updated Makefile to support windows (#128)
Browse files Browse the repository at this point in the history
* Fix #123 : updated Makefile to support windows

* Added steps in CONTRIBUTING.md for how to install make for windows

* added note for make installation in windows

* fixed pipeline issue

Co-authored-by: gaurav pandey <gaurav_pandey@epam.com>
  • Loading branch information
gauravp446 and gaurav pandey authored Nov 2, 2021
1 parent 6c11a3a commit 8521a7d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ environment** install an editable version of `drf-user` along with its tests,
docs requirements and to avoid committing code that violates our style guide, we
use [pre-commit](https://pre-commit.com/) hooks:

Note : For **windows** users, please refer this link to install choco [here](https://chocolatey.org/install) and then use following command to setup make

```sh
$ choco install make
```

```sh
(env) $ cd drf-user
(env) $ make install
Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ VIRTUALENV = virtualenv --python=python3
PYTHON = $(VENV)/bin/python
VENV := $(shell echo $${VIRTUAL_ENV-.venv})

# make it work on windows too
ifeq ($(OS), Windows_NT)
VENV = venv
PYTHON=$(VENV)/Scripts/python
endif

TEST_FLAGS=--verbosity=2
COVER_FLAGS=--source=drf_user

Expand Down

0 comments on commit 8521a7d

Please sign in to comment.