Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev dependecies to avoid issues for latest version #125

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

inovizz
Copy link
Contributor

@inovizz inovizz commented Sep 20, 2021

Description

Pin all dependencies in requirements-dev.txt

Motivation and Context

pin dependencies, run commands and see everything runs fine.

Have you tested this? If so, how?

Yes, it works.

image

image

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via interrogate drf_user (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.md.
    • Manually update both the README.md and docs/index.rst for any new changes.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Issue

Resolves #120

@sumit4613
Copy link
Member

@inovizz Can you please pin dependencies in requirements.txt as well, if possible. Otherwise, I'll create a separate issue for that.
BTW thanks for working on it. ❤️

@inovizz
Copy link
Contributor Author

inovizz commented Sep 20, 2021

Yes, I'll work further on this in sometime.

requirements-dev.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #125 (56c1926) into master (567cf6a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          20       20           
  Lines         649      649           
=======================================
  Hits          621      621           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567cf6a...56c1926. Read the comment docs.

@inovizz
Copy link
Contributor Author

inovizz commented Sep 20, 2021

@inovizz Can you please pin dependencies in requirements.txt as well, if possible. Otherwise, I'll create a separate issue for that.
BTW thanks for working on it. ❤️

Hi @sumit4613 - I think, I'll raise a separate PR to fix dependencies in the requirements.txt file.

Also, before that, I'll probably ask again that which DRF and Django version we plan to support? I propose Django 3.2.7 which is an LTS version and should be valid till 2024. DRF could be 3.12.x series version. What do you think?

cc @iamhssingh

@inovizz inovizz requested a review from sumit4613 September 21, 2021 09:19
Copy link
Member

@sumit4613 sumit4613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thanks @inovizz for this.

@sumit4613 sumit4613 merged commit 6c11a3a into 101Loop:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin all dependencies in requirements-dev.txt.
2 participants