[FEATURE] Supporter la Flat config ESLint #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
changed the title
yannbertrand
commented
May 22, 2024
xav-car
approved these changes
May 22, 2024
VincentHardouin
approved these changes
May 23, 2024
pix-service-auto-merge
pushed a commit
that referenced
this pull request
May 23, 2024
# [1.2.0](v1.1.3...v1.2.0) (2024-05-23) ### 🚀 Amélioration - [#22](#22) Supporter la Flat config ESLint
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans la version 9 d'ESLint, les fichiers de configuration changent de format. On parle de "Flat" config. Pour pouvoir faire cette montée de version il est nécessaire d'anticiper la migration de format de fichier de configuration.
🤖 Proposition
Intégrer la configuration de
@1024pix/eslint-configdans@1024pix/eslint-pluginvia un export custom@1024pix/eslint-plugin/config. Ainsi il est possible de faire le choix d'utiliser ce nouveau format de fichier de config. Toutes les dépendances de notre config ont donc été installées dans ce projet.Une fonctionnalité bienvenue est que nous pouvons maintenant exposer un "plugin" custom dans une "config", une fois toutes les migrations effectuées une seule dépendance sera donc nécessaire pour les utilisateurs de
@1024pix/eslint-config/plugin.🌈 Remarques
Pour le moment on doit rester en CJS avant de monter en v9 pour pouvoir utiliser ESM, ce sera un breaking change à venir.
💯 Pour tester
Voir 1024pix/pix#8995 pour la migration API.