feat(api): supports ids filter for GET /api/skills

1024pix · Dec 24, 2024 · 79adce8 · 79adce8
1 parent e3ccce8
commit 79adce8
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 3 deletions.
diff --git a/api/lib/application/skills/skills.js b/api/lib/application/skills/skills.js
@@ -9,10 +9,11 @@ import {
 } from '../../infrastructure/repositories/index.js';
 import * as updatedRecordNotifier from '../../infrastructure/event-notifier/updated-record-notifier.js';
 import { generateNewId } from '../../infrastructure/utils/id-generator.js';
-import { cloneSkill } from '../../domain/usecases/index.js';
+import { cloneSkill, listSkills } from '../../domain/usecases/index.js';
 import * as pixApiClient from '../../infrastructure/pix-api-client.js';
 import { logger } from '../../infrastructure/logger.js';
 import { skillSerializer } from '../../infrastructure/serializers/jsonapi/index.js';
+import { extractParameters } from '../../infrastructure/utils/query-params-utils.js';
 
 export async function clone(request, h) {
   try {
@@ -36,9 +37,10 @@ export async function clone(request, h) {
   }
 }
 
-export async function list() {
+export async function list(req) {
   try {
-    const skills = await skillRepository.list();
+    const params = extractParameters(req.query);
+    const skills = await listSkills(params);
     return skillSerializer.serialize(skills);
   } catch (err) {
     logger.error(err);

diff --git a/api/lib/domain/usecases/index.js b/api/lib/domain/usecases/index.js
@@ -12,6 +12,7 @@ export * from './get-phrase-translations-url.js';
 export * from './get-competence-challenges-production-overview.js';
 export * from './get-competence-challenges-workbench-overview.js';
 export * from './import-translations.js';
+export * from './list-skills.js';
 export * from './modify-localized-challenge.js';
 export * from './preview-challenge.js';
 export * from './proxy-delete-request-to-airtable.js';

diff --git a/api/lib/domain/usecases/list-skills.js b/api/lib/domain/usecases/list-skills.js
@@ -0,0 +1,8 @@
+import { skillRepository } from '../../infrastructure/repositories/index.js';
+
+export async function listSkills({ filter }) {
+  if (filter.ids) {
+    return skillRepository.getManyByAirtableIds(filter.ids);
+  }
+  return skillRepository.list();
+}
diff --git a/api/lib/infrastructure/datasources/airtable/skill-datasource.js b/api/lib/infrastructure/datasources/airtable/skill-datasource.js
@@ -87,6 +87,14 @@ export const skillDatasource = datasource.extend({
     return body;
   },
 
+  async getManyByAirtableIds(ids) {
+    const airtableRawObjects = await findRecords(this.tableName, {
+      filterByFormula: `OR(${ids.map((id) => `RECORD_ID() = ${stringValue(id)}`).join(', ')})`,
+    });
+    if (airtableRawObjects.length === 0) return undefined;
+    return airtableRawObjects.map(this.fromAirTableObject);
+  },
+
   async filterByTubeId(tubeId) {
     const airtableRawObjects = await findRecords(this.tableName, {
       filterByFormula: `{Tube (id persistant)} = ${stringValue(tubeId)}`,

diff --git a/api/lib/infrastructure/repositories/skill-repository.js b/api/lib/infrastructure/repositories/skill-repository.js
@@ -26,6 +26,13 @@ export async function get(id) {
   return toDomain(skillDTO, translations);
 }
 
+export async function getManyByAirtableIds(ids) {
+  const datasourceSkills = await skillDatasource.getManyByAirtableIds(ids);
+  if (!datasourceSkills) return [];
+  const translations = await translationRepository.listByEntities(model, datasourceSkills.map(({ id }) => id));
+  return toDomainList(datasourceSkills, translations);
+}
+
 export async function listByTubeId(tubeId) {
   const datasourceSkills = await skillDatasource.filterByTubeId(tubeId);
   const translations = await translationRepository.listByEntities(model, datasourceSkills.map(({ id }) => id));