[FEATURE] Déplacer la logique de clonage côté back (PIX-13710) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlepage
added
👀 Func Review Needed
team-contenu
|
Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr755.osc-fr1.scalingo.io |
Jeremiejade
force-pushed
the
pix-13710-clone-skill
branch
from
88c57ec to
c55a14e
Compare
Eithliu
force-pushed
the
pix-13710-clone-skill
branch
from
c55a14e to
e3876d6
Compare
Jeremiejade
force-pushed
the
pix-13710-clone-skill
branch
from
e3876d6 to
6c75357
Compare
Eithliu
force-pushed
the
pix-13710-clone-skill
branch
from
172d421 to
2053397
Compare
Eithliu
force-pushed
the
pix-13710-clone-skill
branch
2 times, most recently
from
c9ccffa to
b09e16e
Compare
fael-b
approved these changes
Sep 6, 2024
Jeremiejade
approved these changes
Sep 6, 2024
Jeremiejade
added
Func Review OK
🚀 Ready to Merge
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
Co-authored-by: Fael Bassetti <fael.bassetti@pix.fr> Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr> co-authored-by: Iris Benoit <iris.benoit@pix.fr>
Co-authored-by: Iris Benoît-Martin <iris.benoit-martin@pix.fr> Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr>
co-authored-by: Iris Benoit <iris.benoit@pix.fr> Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
co-authored-by: Iris Benoit <iris.benoit@pix.fr> Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
co-authored-by: Iris Benoit <iris.benoit@pix.fr> Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
co-authored-by: Iris Benoit <iris.benoit@pix.fr> Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
pix-service-auto-merge
force-pushed
the
pix-13710-clone-skill
branch
from
4c57352 to
a150e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La logique de clonage se faisait côté front. Dans un but de cohérence, il faut la déplacer dans le back via l'appel d'une route.
🤖 Proposition
Déplacer le code qui concerne le clonage dans le back. Modifier le front pour que l'appel se fasse au back.
🌈 Remarques
Penser à rajouter un test de vérification que les challenges non
primaryne soient pas clonés.💯 Pour tester
Tests au vert,
Test fonctionnel de clonage de skill et s'assurer que tout se déroule sans accroc.