Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Crash de l’appli lorsqu’on rafraîchit sur détail acquis/épreuve (PIX-14085) #756

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Sep 5, 2024

🦄 Problème

Impossible de rafraîchir la page quand on est sur détail Acquis ou Épreuve.

Il y a un appel à ember-intl qui est fait trop tôt.

🤖 Proposition

Rendre l’appel à ember-intl lazy.

🌈 Remarques

N/A

💯 Pour tester

Aller sur le détail d’un acquis et rafraîchir la page.
Aller sur le détail d’une épreuve et rafraîchir la page.
Vérifier également que le message de changelog par défaut fonctionne toujours.

@nlepage nlepage self-assigned this Sep 5, 2024
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://pix-lcms-review-pr756.osc-fr1.scalingo.io
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-lcms-review-pr756/environment

Copy link
Contributor

@Eithliu Eithliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞 🥝 🍒 🍓 LGTM 🍓 🍒 🥝 🌞

@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-14085-fix-skill-challenge-refresh branch from 24ab15d to 81c494b Compare September 6, 2024 08:55
@pix-service-auto-merge pix-service-auto-merge merged commit caa01bd into dev Sep 6, 2024
3 of 4 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-14085-fix-skill-challenge-refresh branch September 6, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants