[TECH] Utiliser les variables CSS plutôt que SCSS #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr606.review.pix.fr |
Comment on lines
+19
to
+20
| &--grey, | ||
| &--neutral { |
There was a problem hiding this comment.
C'est curieux ces changements 🤔 c'est le linter ?
There was a problem hiding this comment.
Mon formateur 😅 j'ai viré d'autres modifs mais j'ai zappé celles ci
There was a problem hiding this comment.
C'est dommage parce que ça fait un peu de bruit pour rien 😬 Mais c'est pas très grave 😄
frinyvonnick
approved these changes
Apr 11, 2024
xav-car
approved these changes
Apr 11, 2024
mirawlin
approved these changes
Apr 11, 2024
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [45.0.16](v45.0.15...v45.0.16) (2024-04-11) ### 🏗️ Tech - [#606](#606) Utiliser les variables CSS plutôt que SCSS
|
🎉 This PR is included in version 45.0.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
xav-car
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [45.0.16](v45.0.15...v45.0.16) (2024-04-11) ### 🏗️ Tech - [#606](#606) Utiliser les variables CSS plutôt que SCSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
On utilise des variables SCSS dépréciées.
🎁 Proposition
Les remplacer par les variables CSS correspondantes.
🌟 Remarques
RAS
🎅 Pour tester
Vérifier que les valeurs sont bien les mêmes.