[FEATURE] Gérer l'abscence de label pour les inputs et textarea #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasferraina
added
🚧 Development in progress
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr617.review.pix.fr |
matthiasferraina
force-pushed
the
pix-handle-no-label-on-input
branch
2 times, most recently
from
1aafce6 to
64ff13f
Compare
La-toile-cosmique
approved these changes
Apr 30, 2024
matthiasferraina
force-pushed
the
pix-handle-no-label-on-input
branch
2 times, most recently
from
20c91bb to
cf89447
Compare
Jeyffrey
approved these changes
May 2, 2024
matthiasferraina
added
Func Review OK
Tech review OK
🚀 Ready to Merge
and removed
🚧 Development in progress
pix-service-auto-merge
force-pushed
the
pix-handle-no-label-on-input
branch
from
cf89447 to
1e911a4
Compare
pix-service-auto-merge
pushed a commit
that referenced
this pull request
May 2, 2024
# [45.2.0](v45.1.5...v45.2.0) (2024-05-02) ### 🚀 Amélioration - [#617](#617) Gérer l'abscence de label pour les inputs et textarea
|
🎉 This PR is included in version 45.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Actuellement, Il n'est pas possible d'utiliser les composants
PixInputetPixTextareade la version 45.0.0 de pix-ui dans Pix App. En effet, si on ne passe pas un label en yield aux composantsPixInputetPixTextarea, un élément html label vide est quand même généré par ces composants. Cela cause des problèmes d'accessibilité et des regressions visuelles.🎁 Proposition
Utiliser la gestion de l'absence de label à la manière du
PixSelect.🎅 Pour tester
Aller sur storyBook
Constater l'absence de label pour les
PixInputetPixTextareaen inspectant le html des éléments concernés