Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Permettre de trier les données de PixTable (PIX-15560) #783

Merged
merged 5 commits into from
Dec 13, 2024
Merged

[FEATURE] Permettre de trier les données de PixTable (PIX-15560) #783

merged 5 commits into from
Dec 13, 2024

Conversation

fael-b
Copy link
Contributor

@fael-b fael-b commented Dec 6, 2024 •
edited by Eithliu
Loading

🎄 Problème

On ne peut pas facilement trier les lignes d'un tableau PixTable.

🎁 Proposition

Ajout de la gestion de l'état du tri du tableau.

🌟 Remarques

Il existe un dummy /table pour qui est motivé de faire tourner cette PR en local.

🎅 Pour tester

@fael-b fael-b added 🚧 Development in progress Work In Progress cross-team Toutes les équipes de dev team-contenu labels Dec 6, 2024
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr783.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr783/environment

@fael-b fael-b force-pushed the pix-15560-make-table-sortable branch 2 times, most recently from acfaab8 to fef18aa Compare December 6, 2024 12:43
xav-car

This comment was marked as resolved.

Sign in to view

@fael-b fael-b force-pushed the pix-15560-make-table-sortable branch from fef18aa to 72ba020 Compare December 6, 2024 15:35
@Jeremiejade Jeremiejade force-pushed the pix-15560-make-table-sortable branch from 72ba020 to 59372f0 Compare December 9, 2024 15:47
@fael-b fael-b force-pushed the pix-15560-make-table-sortable branch from 59372f0 to 796ef05 Compare December 9, 2024 17:04
@Eithliu Eithliu force-pushed the pix-15560-make-table-sortable branch 3 times, most recently from e605c5a to 36263bc Compare December 11, 2024 11:03
@fael-b fael-b force-pushed the pix-15560-make-table-sortable branch 3 times, most recently from 7bdf848 to fc406b4 Compare December 11, 2024 16:10
@Eithliu Eithliu removed the 🚧 Development in progress Work In Progress label Dec 11, 2024
@Eithliu Eithliu changed the title [FEATURE] Permettre de trier les lignes de PixTable (PIX-15560) [FEATURE] Permettre de trier les colonnes de PixTable (PIX-15560) Dec 11, 2024
@Eithliu Eithliu changed the title [FEATURE] Permettre de trier les colonnes de PixTable (PIX-15560) [FEATURE] Permettre de trier les données de PixTable (PIX-15560) Dec 11, 2024
@Eithliu Eithliu changed the base branch from dev to pix-15682-refacto-pix-table December 11, 2024 16:19
@Eithliu Eithliu marked this pull request as ready for review December 11, 2024 16:19
@Jeremiejade Jeremiejade force-pushed the pix-15560-make-table-sortable branch from fc406b4 to 4882591 Compare December 12, 2024 10:01
@Jeremiejade Jeremiejade force-pushed the pix-15560-make-table-sortable branch from 4882591 to c83b492 Compare December 12, 2024 10:12
Eithliu
Eithliu approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Eithliu Eithliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄 🎅 🎁 LGTM 🎁 🎅 🎄

Base automatically changed from pix-15682-refacto-pix-table to dev December 13, 2024 08:46
lionelB
lionelB approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@lionelB lionelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est top ! merci

lionelB
lionelB reviewed Dec 13, 2024
View reviewed changes
app/stories/pix-table.stories.js
@@ -103,4 +93,7 @@ Default.args = {
age: 25,
},
],
onNameSort: () => {
Copy link
Member

@lionelB lionelB Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion : Je ne vois pas ou c'est utilisé, est ce que c'est encore nécessaire ?

Copy link
Contributor

@Jeremiejade Jeremiejade Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'était pour l"exemple mais aussi pour pouvoir afficher les icones de sort il faut qu'une fonction soit transmise sur le @OnSort.

Eithliu and others added 5 commits December 13, 2024 11:00
@Eithliu @Jeremiejade
feat(table): add @OnSort on pix table column
3115209 
Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr>
Co-authored-by: Fael Bassetti <fael.bassetti@pix.fr>

# Conflicts:
#	addon/components/pix-table-column.js
@Eithliu @Jeremiejade @fael-b
docs(table): update table stories
e923e5f 
Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr>
Co-authored-by: Fael Bassetti <fael.bassetti@pix.fr>
@Eithliu @Jeremiejade @fael-b
feat(table): add a dummy page for table
7bfd688 
Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr>
Co-authored-by: Fael Bassetti <fael.bassetti@pix.fr>
@fael-b @Eithliu @Jeremiejade
feat(table): display sort icons corresponding to column type
2d1500e 
Co-authored-by: Iris Benoit-Martin <iris.benoit-martin@pix.fr>
Co-authored-by: Jérémie Jadé <jeremie.jade@pix.fr>
@Jeremiejade @Eithliu
doc(table): Add sort alphabetic example
a00d884 
Co-authored-by: Iris Benoit <iris.benoit@pix.fr>
@Jeremiejade Jeremiejade force-pushed the pix-15560-make-table-sortable branch from c83b492 to a00d884 Compare December 13, 2024 10:01
@pix-service-auto-merge pix-service-auto-merge merged commit 54ff81e into dev Dec 13, 2024
14 checks passed
pix-service-auto-merge pushed a commit that referenced this pull request Dec 13, 2024
@semantic-release-bot
chore(release): 51.4.0 [skip ci]
5e45250 
# [51.4.0](v51.3.0...v51.4.0) (2024-12-13)

### 🚀 Amélioration

- [#783](#783) Permettre de trier les données de `PixTable` (PIX-15560)
@pix-service-auto-merge
Copy link
Contributor

🎉 This PR is included in version 51.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeremiejade Jeremiejade Jeremiejade left review comments

@lionelB lionelB lionelB approved these changes

@xav-car xav-car xav-car approved these changes

@Eithliu Eithliu Eithliu approved these changes

Assignees

@Eithliu Eithliu

@fael-b fael-b

@Jeremiejade Jeremiejade

Labels
cross-team Toutes les équipes de dev Design review OK Func Review OK released 🚀 Ready to Merge team-contenu Tech review OK ⚠️ PR Inheritance :warning: PR Inheritance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fael-b @pix-bot-github @pix-service-auto-merge @lionelB @Eithliu @xav-car @Jeremiejade