Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajout des icônes stopwatch et barsUp (PIX-15723) #790

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

er-lim
Copy link
Contributor

@er-lim er-lim commented Dec 13, 2024

💥 BREAKING_CHANGES

🎄 Problème

Il manque les icônes stopwatch et barsUp 😢

🎁 Proposition

Les ajouter 🎉

🌟 Remarques

RAS

🎅 Pour tester

  • Aller sur la page listant les icônes
  • Vérifier que les icônes stopwatch et barsUp s'affichent bien 🎉

@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr790.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr790/environment

addon/helpers/icons.js Outdated Show resolved Hide resolved
Copy link
Contributor

@xav-car xav-car left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moyennant la suppression du barUp_plain, c'est OKAY

Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr>
Co-authored-by: Diane Cordier <diane.cordier@pix.fr>
@pix-service-auto-merge pix-service-auto-merge merged commit 3b7c791 into dev Dec 13, 2024
7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-15723-add-icons branch December 13, 2024 13:18
pix-service-auto-merge pushed a commit that referenced this pull request Dec 13, 2024
# [51.6.0](v51.5.0...v51.6.0) (2024-12-13)

### 🚀 Amélioration

- [#790](#790) Ajout des icônes stopwatch et barsUp (PIX-15723)
@pix-service-auto-merge
Copy link
Contributor

🎉 This PR is included in version 51.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants