feat(admin): add active authentication methods count

1024pix · Jan 2, 2025 · d6a6309 · d6a6309
1 parent 4a8c7c3
commit d6a6309
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/admin/app/models/user.js b/admin/app/models/user.js
@@ -51,4 +51,11 @@ export default class User extends Model {
   get participationsCount() {
     return this.participations.length;
   }
+  get loginOptionsCount() {
+    console.log(this.authenticationMethods.length);
+    const result =
+      this.username && this.email ? this.authenticationMethods.length + 1 : this.authenticationMethods.length;
+    console.log(result);
+    return result;
+  }
 }
diff --git a/admin/app/templates/authenticated/users/get.hbs b/admin/app/templates/authenticated/users/get.hbs
@@ -20,6 +20,7 @@
 
     <LinkTo @route="authenticated.users.get.authentication-methods" @model={{@model}} class="navbar-item">
       {{t "pages.user-details.navbar.authentication-methods"}}
+      ({{@model.loginOptionsCount}})
     </LinkTo>
 
     <LinkTo @route="authenticated.users.get.profile" @model={{@model}} class="navbar-item">

diff --git a/admin/tests/acceptance/authenticated/users/get-test.js b/admin/tests/acceptance/authenticated/users/get-test.js
@@ -24,10 +24,14 @@ module('Acceptance | authenticated/users/get', function (hooks) {
   test('displays user detail information page', async function (assert) {
     // given
     this.intl = this.owner.lookup('service:intl');
-    const user = await _buildAndAuthenticateUser(this.server, { email: 'john.harry@example.net', username: null });
+    const user = await _buildAndAuthenticateUser(this.server, {
+      email: 'john.harry@example.net',
+      username: 'john.harry0101',
+    });
     const expectedOrganizationMembershipsCount = 2;
     const expectedParticipationCount = 1;
     const expectedCertificationCenterCount = 3;
+    const expectedLoginOptionsCount = 3;
 
     // when
     const screen = await visit(`/users/${user.id}`);
@@ -37,7 +41,9 @@ module('Acceptance | authenticated/users/get', function (hooks) {
 
     const userNavigation = within(screen.getByLabelText("Navigation de la section détails d'un utilisateur"));
     assert.dom(userNavigation.getByRole('link', { name: 'Informations prescrit' })).exists();
-    assert.dom(userNavigation.getByRole('link', { name: 'Méthodes de connexion' })).exists();
+    assert
+      .dom(userNavigation.getByRole('link', { name: `Méthodes de connexion (${expectedLoginOptionsCount})` }))
+      .exists();
     assert.dom(userNavigation.getByRole('link', { name: 'Profil' })).exists();
     assert.dom(userNavigation.getByRole('link', { name: `Participations (${expectedParticipationCount})` })).exists();
     assert
@@ -128,8 +134,16 @@ module('Acceptance | authenticated/users/get', function (hooks) {
         organizationMemberships: [organizationMembership],
         certificationCenterMemberships: [certificationCenterMembership],
       });
+      const expectedLoginOptionsCountBeforeAnonymisation = 3;
+      const expectedLoginOptionsCountAfterAnonymisation = 0;
 
       const screen = await visit(`/users/${userToAnonymise.id}`);
+      assert
+        .dom(
+          screen.getByRole('link', { name: `Méthodes de connexion (${expectedLoginOptionsCountBeforeAnonymisation})` }),
+        )
+        .exists();
+
       await click(screen.getByRole('button', { name: 'Anonymiser cet utilisateur' }));
 
       await screen.findByRole('dialog');
@@ -140,7 +154,9 @@ module('Acceptance | authenticated/users/get', function (hooks) {
       assert.dom(screen.getByText('Nom : (anonymised)')).exists();
 
       // when & then #2
-      await click(screen.getByRole('link', { name: 'Méthodes de connexion' }));
+      await click(
+        screen.getByRole('link', { name: `Méthodes de connexion (${expectedLoginOptionsCountAfterAnonymisation})` }),
+      );
       assert.dom(screen.getByLabelText("L'utilisateur n'a pas de méthode de connexion avec identifiant")).exists();
       assert.dom(screen.getByLabelText("L'utilisateur n'a pas de méthode de connexion avec adresse e-mail")).exists();
       assert.dom(screen.getByLabelText("L'utilisateur n'a pas de méthode de connexion Médiacentre")).exists();
@@ -218,11 +234,11 @@ module('Acceptance | authenticated/users/get', function (hooks) {
 
   module('when administrator click on remove authentication method button', function () {
     test('not displays remove link and display unchecked icon', async function (assert) {
+      const expectedLoginOptionsCount = 2;
       // given
       const user = await _buildAndAuthenticateUser(this.server, { email: 'john.harry@example.net', username: null });
       const screen = await visit(`/users/${user.id}`);
-      await click(screen.getByRole('link', { name: 'Méthodes de connexion' }));
-
+      await click(screen.getByRole('link', { name: `Méthodes de connexion (${expectedLoginOptionsCount})` }));
       // when
       await click(screen.getAllByRole('button', { name: 'Supprimer' })[0]);