Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] ✨ Ajoute une stratégie de contrôle plus strict pour l'accès au endpoint Parcoursup (PIX-15801) #10881

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[FEATURE] ✨ Ajoute une stratégie de contrôle plus strict pour l'accès au endpoint Parcoursup (PIX-15801) #10881

merged 1 commit into from
Dec 24, 2024
+115 −15

Conversation

yaf
Copy link
Member

@yaf yaf commented Dec 20, 2024 •
edited by alexandrecoin
Loading

🎄 Problème

Le endpoint parcourSup était réservé aux personnes ayant un accès super admin

🎁 Proposition

Mettre en place un contrôle du endpoint via un token spécifique parcoursup.

🧦 Remarques

🎅 Pour tester

Sur https://api-pr10881.review.pix.fr/api/documentation, générer un token valide avec les bons client_id, client_secret et scope

TOKEN=<token>
curl https://api-pr10881.review.pix.fr/api/parcoursup/students/123456789OK/certification \
    -H "Authorization: Bearer $TOKEN" \
    -H "Content-Type: application/json" \
    -X GET

@yaf yaf changed the title [FEATURE] ✨ api: create jwt-parcoursup authentication strategy [FEATURE] ✨ Ajoute une stratégie de contrôle plus strict pour l'accès au endpoint Parcoursup (PIX-15801) Dec 20, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@yaf yaf marked this pull request as ready for review December 20, 2024 14:29
@yaf yaf added the team-acces label Dec 20, 2024
@HEYGUL HEYGUL force-pushed the pix-15801-add-parcoursup-authentication branch from 1812cab to 9a04deb Compare December 23, 2024 09:50
@HEYGUL HEYGUL requested a review from a team December 23, 2024 09:54
@HEYGUL
Copy link
Contributor

HEYGUL commented Dec 23, 2024

Func review ok

lego-technix
lego-technix approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et validé avec succès pour l'équipe Accès

@P-Jeremy @alexandrecoin
@AndreiaPena @Jeyffrey @yaf
✨ api: create jwt-parcoursup authentication strategy
49abdd8 
Co-authored-by: Alexandre COIN <alexandre.pc.coin@gmail.com>
Co-authored-by: Andreia Pena <58915422+AndreiaPena@users.noreply.github.com>
Co-authored-by: Geoffroy Begouaussel <geoffroy.begouaussel@pix.fr>
Co-authored-by: Jérémy PLUQUET <37305474+D0C702WH0@users.noreply.github.com>
Co-authored-by: Yannick François <yannick.francois@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-15801-add-parcoursup-authentication branch from 9a04deb to 49abdd8 Compare December 24, 2024 10:35
@pix-service-auto-merge pix-service-auto-merge merged commit 17ce069 into dev Dec 24, 2024
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-15801-add-parcoursup-authentication branch December 24, 2024 10:41
HEYGUL pushed a commit that referenced this pull request Dec 24, 2024
@pix-service-auto-merge @HEYGUL
[FEATURE] ✨ Ajoute une stratégie de contrôle plus strict pour l'accès…
ef00971 
… au endpoint Parcoursup (PIX-15801)

 #10881
@yaf yaf added the Parcoursup label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego-technix lego-technix lego-technix approved these changes

Assignees

@yaf yaf

@Steph0 Steph0

@Jeyffrey Jeyffrey

@alexandrecoin alexandrecoin

@P-Jeremy P-Jeremy

@AndreiaPena AndreiaPena

Labels
Func Review OK PO validated functionally the PR Parcoursup 🚀 Ready to Merge team-acces team-certif Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@yaf @pix-bot-github @HEYGUL @lego-technix @Steph0 @Jeyffrey @alexandrecoin @P-Jeremy @AndreiaPena @pix-service-auto-merge