Upgrade some WPPrinter methods to protected #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `php ayuco add`, the following errors were getting thrown: ``` PHP Fatal error: Access level to WPMVC\Commands\Parser\WPPrinter::hasNodeWithComments() must be protected (as in class PhpParser\PrettyPrinter\Standard) or weaker in /srv/www/wordpress-mvc/public_html/wp-content/plugins/my-plugin/vendor/10quality/wpmvc-commands/src/Parser/WPPrinter.php on line 25 ``` and ``` PHP Fatal error: Access level to WPMVC\Commands\Parser\WPPrinter::pMaybeMultiline() must be protected (as in class PhpParser\PrettyPrinter\Standard) or weaker in /srv/www/wordpress-mvc/public_html/wp-content/plugins/my-project/vendor/10quality/wpmvc-commands/src/Parser/WPPrinter.php on line 25 ``` I updated the methods to protected in my project now they work as expected. Looks like the PHP-Parser dependency updated the parent methods to protected a couple months ago in nikic/PHP-Parser@1d1bc8a#diff-d9d234fe7bea15ea81db29f63acb50bfe9c8e09bbb3ff7267bb319945fb8fc01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
php ayuco add, the following errors were getting thrown for me:and
I updated the methods to protected in my project and now they work as expected.
Looks like the PHP-Parser dependency updated the parent methods to protected a couple months ago in nikic/PHP-Parser@1d1bc8a#diff-d9d234fe7bea15ea81db29f63acb50bfe9c8e09bbb3ff7267bb319945fb8fc01