Feature/linaria #263
Feature/linaria #263
Conversation
🦋 Changeset detectedLatest commit: 19cf806 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This is blocked by pmmmwh/react-refresh-webpack-plugin#726 |
This reverts commit b4a8d0d.
| use: [ | ||
| require.resolve('thread-loader'), | ||
| { | ||
| loader: require.resolve('./plugins/noop-loader'), |
There was a problem hiding this comment.
thread-loader is incompatible with linaria (apparently there's a way but don't feel like it's worth it). I added a noop-loader just in case projects are manipulating rules and if simply remove we might introduce off-by-one errors.
I never really understood the benefits of thread-loader so I'm not concerned about us just ditching it.... I believe this is a relatively safe change that shouldn't be breaking but open to your thoughts @Antonio-Laguna
There was a problem hiding this comment.
I think you're correct! I don't believe this is breaking! The only effect is that it might (only might) reduce speed by a tiny bit given there are no extra workers.
|
not sure why tests are failing UPDATE: fixed. |
Antonio-Laguna
left a comment
Antonio-Laguna
left a comment
There was a problem hiding this comment.
This LGTM!
I've added some minor nitpick formatting with casing and such. I did double-check that on their repo's README they always capitalize. Not a blocker by any means!
| use: [ | ||
| require.resolve('thread-loader'), | ||
| { | ||
| loader: require.resolve('./plugins/noop-loader'), |
There was a problem hiding this comment.
I think you're correct! I don't believe this is breaking! The only effect is that it might (only might) reduce speed by a tiny bit given there are no extra workers.
| "@babel/core": "^7.17.8", | ||
| "@babel/eslint-parser": "^7.17.0", | ||
| "@pmmmwh/react-refresh-webpack-plugin": "^0.5.5", | ||
| "@pmmmwh/react-refresh-webpack-plugin": "https://github.com/nicholasio/react-refresh-webpack-plugin.git", |
There was a problem hiding this comment.
Is this fork related to this change? I'm mainly curious
There was a problem hiding this comment.
Yes - hopefully we can go back to upstream once this is merged and released pmmmwh/react-refresh-webpack-plugin#726
Co-authored-by: Antonio Laguna <antonio.laguna@10up.com>
Co-authored-by: Antonio Laguna <antonio.laguna@10up.com>
Co-authored-by: Antonio Laguna <antonio.laguna@10up.com>
Co-authored-by: Antonio Laguna <antonio.laguna@10up.com>
Co-authored-by: Antonio Laguna <antonio.laguna@10up.com>
2 participants
This PR adds support for linaria, which is commonly used to share styled react components between front-end and backend (Gutenberg).
Description of the Change
Instructs 10up-toolkit on how to compile Linaria code.
Alternate Designs
Possible Drawbacks
Had to use my fork of the react-fast-refresh-webpack plugin until pmmmwh/react-refresh-webpack-plugin#726 gets merged.
Verification Process
Checklist: