Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for publicPath #330

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Adding support for publicPath #330

merged 8 commits into from
Nov 6, 2023

Conversation

Antonio-Laguna
Copy link
Member

Related Issue/RFC: #213

Description of the Change

Adds support for publicPath to be configured.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: b4f6c08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Antonio-Laguna Antonio-Laguna linked an issue Oct 4, 2023 that may be closed by this pull request
1 task
@Antonio-Laguna
Copy link
Member Author

@nicholasio I went to update the snapshots and got weird errors do you know what this could be?

Screenshot 2023-10-04 at 12 53 25

@nicholasio nicholasio merged commit 0c969ef into develop Nov 6, 2023
5 checks passed
@nicholasio nicholasio deleted the feature/public-path branch November 6, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publicPath issue when code-splitting in production
2 participants