Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Update to use @10up/eslint-config/react and fix possible warnings and errors #2297

Closed
Rahmon opened this issue Aug 10, 2021 · 0 comments · Fixed by #2306
Closed

BUG: Update to use @10up/eslint-config/react and fix possible warnings and errors #2297

Rahmon opened this issue Aug 10, 2021 · 0 comments · Fixed by #2306
Assignees
@Rahmon
Labels
confirmed bug enhancement high priority
Milestone
3.6.2

Comments

@Rahmon
Copy link
Contributor

Rahmon commented Aug 10, 2021

Describe the bug
We should use @10up/eslint-config/react to lint React rules such as missing dependencies in React Hooks. So, we need to update the .eslintrc.js, run npm run lint-js, fix the warnings and errors, and remove eslint deps.

This PR is a continuation of #2279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rahmon Rahmon

Labels
confirmed bug enhancement high priority
Projects
None yet
Milestone
3.6.2
Development

Successfully merging a pull request may close this issue.

Enable @10up/eslint-config/react and fix warnings and erros 10up/ElasticPress
2 participants
@Rahmon @mckdemps