Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable @10up/eslint-config/react and fix warnings and erros #2306

Merged
merged 57 commits into from
Aug 19, 2021
Merged

Enable @10up/eslint-config/react and fix warnings and erros #2306

merged 57 commits into from
Aug 19, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Aug 13, 2021

Description of the Change

This change updates the eslint rules to follow the rules defined in 10up-toolkit and fixes the warnings and errors.

Alternate Designs

Benefits

  • Simplify our building scripts process and transferring and responsibility to 10up-toolkit
  • Reduce the number of packages we require on our package.json file

Possible Drawbacks

Verification Process

In the process of fixing the warnings and errors, some refactoring was necessary. So it's necessary to check if everything is working as expected. Especially in the pages Synonyms and Custom Results.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #2297

Changelog Entry

@Rahmon
Remove custom rules in .eslintrc.js
eaff090
@Rahmon
Fix JSDoc lint issues in autosuggest.js
ade6f01
@Rahmon
Refactor to declare variables after return statement in autosuggest.js
0ca009d
@Rahmon
Fix JSDoc in related-posts/Edit.js
6568e39
@Rahmon
Remove unused 'number' field state in related-posts/Edit.js
20e4185
@Rahmon
Update to use post ID in key instead of array index in
bac0e6e 
related-posts/Edit.js
@Rahmon
Fix JSDoc in related-posts/block.js
cbd2d86
@Rahmon
Fix JSDoc in comments.js
e0d3f7d
@Rahmon
Fix else block with only a if statement
360924a
@Rahmon
Fix else block with only a if statement in dashboard.js
7314114
@Rahmon
Move variable after return statement
9ce6456
@Rahmon
Remove unused React in ordering/index.js
4e509e3
@Rahmon
Fix JSDoc issues in pointers.js
e5255d4
@Rahmon
Disable @wordpress/no-global-event-listener rule in sites-admin.js
42e1837
@Rahmon
Fix JSDoc issues in stats.js
0f6034d
@Rahmon
Fix JSDoc in SynonymsEditor.js
1b9d460
@Rahmon
Convert SynonymsEditor to arrow function
5585c6f
@Rahmon
Fix JSDoc to AlternativeEditor.js
04d4653
@Rahmon
Convert AlternativeEditor component to arrow function
8ac9d25
@Rahmon
Update to use destructuring props in AlternativeEditor.js
87c751b
@Rahmon
Fix JSDoc to AlternativesEditor.js
3198e17
@Rahmon
Convert AlternativesEditor component to arrow function
685f5b6
@Rahmon
Add type attr to button in AlternativesEditor.js
dd62864
@Rahmon
Add type attr to button in SetsEditor.js
164c463
@Rahmon
Convert SetsEditor component to arrow function
dd492b7
@Rahmon
Fix JSDoc to SolrEditor.js
17963b4
@Rahmon
Fix JSDoc to LinkedMultiInput.js
c97ca7c
@Rahmon
Convert LinkedMultiInput component to arrow function
dc38e44
@Rahmon
Fix JSDoc to MultiInput.js
dfffae4
@Rahmon
Convert MultiInput component to arrow function
3184849
@Rahmon
Move searchResults() before render() in pointers.js
f370424
@Rahmon
Add role and keyboard listener on Add Post button in pointers.js
e37cf10
@Rahmon
Update to use ellipsis character in pointers.js
8661793
@Rahmon
Remove array index on keys in pointers.js
f6a7136
@Rahmon
Add role and keyboard listener on Remove Post button in pointers.js
5f65545
@Rahmon
Update to use destructuring on getDefaultResults in pointers.js
6151c59
@Rahmon
Add missing dependency on useEffect in SynonymsEditor.js
babc13d
@Rahmon
Convert SolrEditor component to arrow function
09b3537
@Rahmon
Refactor pointers.js
8550b35
@Rahmon
Remove unnecesary useEffect and useState from LinkedMultiInput.js
e01f626
@Rahmon
Add missing dependencies on useEffect in AlternativeEditor.js
12bc9aa
@Rahmon
Remove unnecesary useEffect and useState from SolrEditor.js
0b02fd4
@Rahmon
Build assets
31722a9
@Rahmon
Remove unnecessary packages due to 10up-toolkit
3f263ee
@Rahmon
Update .babelrc
8d8c541
@Rahmon
Build assets
f6bfe69
@Rahmon Rahmon added this to the 3.6.2 milestone Aug 13, 2021
@Rahmon Rahmon requested a review from felipeelia August 13, 2021 14:37
@felipeelia felipeelia requested a review from JakePT August 16, 2021 13:59
@JakePT
Copy link
Contributor

JakePT commented Aug 17, 2021

@Rahmon Looks good to me.

@Rahmon Rahmon merged commit 35bffb8 into develop Aug 19, 2021
@Rahmon Rahmon deleted the fix/react-warnings-and-errors branch August 19, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakePT JakePT JakePT approved these changes

@felipeelia felipeelia Awaiting requested review from felipeelia

Assignees

@felipeelia felipeelia

@JakePT JakePT

Labels
enhancement high priority
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.

BUG: Update to use @10up/eslint-config/react and fix possible warnings and errors
3 participants
@Rahmon @JakePT @felipeelia