Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show those taxonomies in Facet blocks for which show_ui & public parameter are set to true. #2957

Closed
burhandodhy opened this issue Aug 23, 2022 · 0 comments · Fixed by #2958
Assignees
Labels
enhancement module:facets Issues related to the Facets functionality
Milestone

Comments

@burhandodhy
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Most of the time, developers create a taxonomy that is not available in the admin dashboard, for example the ep_custom_result taxonomy in ElasticPress. Facet Blocks list the name all taxonomies in the select option. In my opinion, we should only list those taxonomies whose public and show_ui parameters are set to true.
image

Describe the solution you'd like

Only show those taxonomies for which show_ui & public both are set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:facets Issues related to the Facets functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants