Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide taxonomies from facet block whose show_ui is set to false. #2958

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR hides the taxonomies from facet block whose show_ui is set to false.

Closes #2957

How to test the Change

  • Go to Widgets screens
  • Add Facet Block
  • Make sure Taxonomy field does not have Custom Result option

Changelog Entry

Changed - Hide taxonomies from facet block whose show_ui is set to false.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.4.0 milestone Aug 23, 2022
@felipeelia
Copy link
Member

@burhandodhy do you mind fixing the conflict on this one so we can merge it? Thanks!

@burhandodhy
Copy link
Contributor Author

@burhandodhy do you mind fixing the conflict on this one so we can merge it? Thanks!

Done

@felipeelia felipeelia merged commit 5acdea4 into develop Oct 11, 2022
@felipeelia felipeelia deleted the fix/2957 branch October 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show those taxonomies in Facet blocks for which show_ui & public parameter are set to true.
2 participants