Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the Facet filter to query only when the value is not empty #3517

Closed
1 task done
burhandodhy opened this issue Jun 27, 2023 · 0 comments · Fixed by #3524
Closed
1 task done

Apply the Facet filter to query only when the value is not empty #3517

burhandodhy opened this issue Jun 27, 2023 · 0 comments · Fixed by #3524
Assignees
Milestone

Comments

@burhandodhy
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

When the facet filter has an empty value in the query string. ElasticPress applies that filter to the query and it cause unwanted search result.

Steps to Reproduce

  1. Add the Facet block.
  2. Apply the facet filter.
  3. Remove the filter value from the query string.
  4. Check the search result

Designs

No response

Describe alternatives you've considered

The filter should be applied to the query only when the value is not empty

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants