Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Restrict applying a facet filter to the query if the filter value is empty. #3524

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix: Restrict applying a facet filter to the query if the filter value is empty. #3524

merged 2 commits into from
Jul 4, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where the facet filter was applied on the query even when the filter value is empty

Closes #3517

How to test the Change

  1. Add the Facet block.
  2. Apply the facet filter.
  3. Remove the filter value from the query string.
  4. Check the search result

Changelog Entry

Fixed - Restrict applying a facet filter to the query if the filter value is empty.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.6.1 milestone Jul 4, 2023
@felipeelia felipeelia merged commit 7723409 into develop Jul 4, 2023
@felipeelia felipeelia deleted the fix/3517 branch July 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

Apply the Facet filter to query only when the value is not empty
2 participants
@burhandodhy @felipeelia