Merge pull request #3524 from 10up/fix/3517

Fix: Restrict applying a facet filter to the query if the filter value is empty.
10up · Jul 4, 2023 · 7723409 · 7723409
2 parents 811bd8b + 7f0cfd4
commit 7723409
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/includes/classes/Feature/Facets/Facets.php b/includes/classes/Feature/Facets/Facets.php
@@ -401,6 +401,9 @@ public function get_selected() {
 
 			foreach ( $filter_names as $filter_name => $type_obj ) {
 				if ( 0 === strpos( $key, $filter_name ) ) {
+					if ( empty( $value ) ) {
+						continue;
+					}
 					$facet = str_replace( $filter_name, '', $key );
 
 					$filters = $type_obj->format_selected( $facet, $value, $filters );

diff --git a/tests/php/features/TestFacet.php b/tests/php/features/TestFacet.php
@@ -105,6 +105,12 @@ public function testGetSelected() {
 		$this->assertSelectedTax( array( $term->slug => true ), 'taxonomy', $selected );
 		$this->assertArrayHasKey( 'post_type', $selected );
 		$this->assertSame( 'posttype', $selected['post_type'] );
+
+		// test when filter value is empty.
+		parse_str( 'ep_filter_category=&ep_filter_othertax=amet&s=', $_GET );
+		$selected = $facet_feature->get_selected();
+		$this->assertArrayNotHasKey( 'category', $selected['taxonomies'] );
+		$this->assertArrayHasKey( 's', $selected );
 	}
 
 	/**