Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosuggest: Helper function to delete cached query #2105

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Autosuggest: Helper function to delete cached query #2105

merged 4 commits into from
Feb 25, 2021

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Feb 25, 2021 •
edited
Loading

Description of the Change

This PR fixes the problem outlined in #2104. It also adds some new actions:

  • ep_wp_cli_after_index
  • ep_after_dashboard_index
  • ep_cli_before_set_search_algorithm_version
  • ep_cli_after_set_search_algorithm_version
  • ep_after_update_feature
  • ep_cli_before_clear_index
  • ep_cli_after_clear_index

Applicable Issues

Closes #2104

Changelog Entry

  • Add new actions: ep_wp_cli_after_index, ep_after_dashboard_index, ep_cli_before_set_search_algorithm_version, ep_cli_after_set_search_algorithm_version, ep_after_update_feature, ep_cli_before_clear_index, and ep_cli_after_clear_index

@felipeelia felipeelia added this to the 3.6.0 milestone Feb 25, 2021
@felipeelia felipeelia self-assigned this Feb 25, 2021
felipeelia and others added 3 commits February 25, 2021 13:58
@felipeelia
Add the ep_cli_clear_index action
e1503d0 
And hook Autosuggest::delete_cached_query() to it
@felipeelia @Rahmon
Rename some actions to keep consistency
5578821 
Co-authored-by: Ramon <rahmon@users.noreply.github.com>
@felipeelia
Autosuggest should be hooked on ep_cli_after_set_search_algorithm_ver…
595680b 
…sion
Rahmon
Rahmon approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@Rahmon Rahmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandwaffle brandwaffle merged commit a38768e into develop Feb 25, 2021
@brandwaffle brandwaffle deleted the fix/issue-2104 branch February 25, 2021 18:23
@felipeelia felipeelia modified the milestones: 3.6.0, 3.5.5 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahmon Rahmon Rahmon approved these changes

@tott tott Awaiting requested review from tott

@brandwaffle brandwaffle Awaiting requested review from brandwaffle

Assignees

@felipeelia felipeelia

Labels
confirmed bug qa
Projects
None yet
Milestone
3.5.5
Development

Successfully merging this pull request may close these issues.

Provide an easy way to clear the query cached for Autosuggest
3 participants
@felipeelia @Rahmon @brandwaffle