WIP: Several fixes for Terms #2420

felipeelia · 2021-10-20T14:26:45Z

So far, this PR:

Fixes BUG: WP_Term_Query always fallback to MySQL when results are empty #2367
Makes sure all tests for the Terms Indexable are really using ES
Fixes compatibility with the object_ids parameter
Sort by term_id and parent instead of term_id.long and parent.long (non-existent subfields)
Fixes some unit tests where terms were not indexed yet
Adjusts how the hierarchical and hide_empty parameters work together

felipeelia added 6 commits October 20, 2021 09:44

Properly short-circuit terms_pre_query on maybe_filter_query

3bf16a0

Check if WP_Term_Query are really using ES

53c5dc6

Terms: Fix object_ids

2740695

Terms tests: fix check for absent $term_query->elasticsearch_success

a9a9cf0

Terms tests: Update terms index before running query

53da012

Remove references to term_id.long and parent.long

8ad32b2

felipeelia added the high priority label Oct 20, 2021

felipeelia added this to the 3.6.4 milestone Oct 20, 2021

felipeelia self-assigned this Oct 20, 2021

Terms: hierarchical and hide_empty changes

0b9c5db

felipeelia assigned Rahmon and unassigned felipeelia Oct 20, 2021

felipeelia requested a review from Rahmon October 20, 2021 17:34

felipeelia mentioned this pull request Oct 21, 2021

WIP: Short circuit maybe_filter_query #2418

Closed

6 tasks

felipeelia merged commit 66099ed into develop Oct 21, 2021

felipeelia deleted the fix/issue-2367 branch October 21, 2021 12:46

felipeelia mentioned this pull request Oct 21, 2021

Check if query is using Elasticsearch on term group #2405

Closed

6 tasks

Rahmon mentioned this pull request Nov 15, 2021

Check if all tests are using Elasticsearch #2335

Closed

Provide feedback