Adjust visuals sync progress #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Dec 2, 2021
There was a problem hiding this comment.
Some issues I found during my tests:
General
- Progress bar doesn't seem to be working. As soon as I click on Sync Now, it goes directly to 100% but if I click on Show log I can see things happening
- If the user pauses the sync and reload the page, the pause/stop should be visible. Clicking on Sync Now will resume it but it is not clear it works like that.
Errors count
In a site with content imported from WooCommerce sample data and tests/wpa/test-docs/content-example.xml, and also wit a script to cause the Limit of total fields [5000] in index [...] has been exceeded error
- 350 posts per page causes a "Request Entity Too Large" error. That is outputted in the Errors tab but the counter isn't updated
- Full log isn't "full". Errors should be outputted in both places, or we need to change the first tab name
- Reducing the 350 to 100 I can see 24 lines of errors in that tab but the count says 123
| @@ -1,5 +1,306 @@ | |||
| #ep-sync-output { | |||
| .elasticpress_page_elasticpress-sync .button:disabled { | |||
There was a problem hiding this comment.
Not a blocker for Beta 1, but we need to get back to this file before the official release and make use of some vars, especially for breakpoints. dashboard.css makes use of that and it increases readability a lot.
| 'sync_stack' => [], | ||
| 'network_alias' => [], | ||
| 'start_time' => microtime( true ), | ||
| 'start_date_time' => $start_date_time ? $start_date_time->format( 'D, F d, Y H:i' ) : false, |
There was a problem hiding this comment.
Not a blocker for Beta 1 but we should have this stored in another format, so people can translate that format later.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry