Add a "request" subcommand #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help when debugging, or otherwise wanting to send arbitrary requests to ElasticSearch, this adds a new `request` sub-command, that is some what similar to the idea of `wp db query` or the like. For example `wp elasticpress request /_cat/indices --method=GET`
felipeelia
changed the title
|
Nice one! |
There was a problem hiding this comment.
Hi @felipeelia I have just one suggestion:
- Have a list of allowed methods and check if the method matches any in the list. If not øn the list, display error message. For example:
wp elasticpress request _cat/indices --method=TESTdoesn't give an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a take over of #2438
To help when debugging, or otherwise wanting to send arbitrary requests to ElasticSearch, this adds a new request sub-command, that is somewhat similar to the idea of
wp db queryor the like.For example
wp elasticpress request _cat/indices --method=GETChangelog Entry
Added: WP-CLI
requestcommand. Props @joehoyle and @felipeelia