Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Check if site is indexable before building index name #2531

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

It seems if you run the following command: wp elasticpress get-indexes on multisite, you will get a list of index names from all sites, even if you have specified a site to not be indexed.

The site won't actually be indexed, but the command will return how that name would look, regardless.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@felipeelia felipeelia added this to the 3.6.6 milestone Dec 17, 2021
@felipeelia felipeelia merged commit 3ff2309 into develop Dec 17, 2021
@felipeelia felipeelia deleted the fix/multisite-get-indexes branch December 17, 2021 21:44
felipeelia added a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants