-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a message when an indexing is stopped by the WP-CLI command #2549
Show a message when an indexing is stopped by the WP-CLI command #2549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rahmon I tried this one following these steps:
- Started a new "full" sync in the dashboard (per page = 2 so it goes slowly)
- Called
wp elasticpress stop-indexing
in the terminal
This is what happened:
- I saw a
Sync interrupted by WP-CLI command
in the log (expected) but if I don't have the log opened I can't know what is happening, asSync in progress
is still visible. - The buttons didn't change, so I can still see "Pause" (but it's already "paused") and "Stop". We probably should trigger the "Stop" behavior, so people can't simply resume it from the dashboard again.
- If I click on "Pause" the button becomes "Resume" and I see "Sync paused" in the logs. Then if I click on "Resume", it will start over.
@felipeelia when you have a chance, could you review it again? |
@Rahmon , I really think the sync should trigger the exact same behavior of a stop. Right now, if someone stops the sync, it'll just "freeze" things, leaving the dashboard user no action. Let's bring that decision to the weekly sync.
|
@felipeelia just to be sure, did you run |
yup! |
"Your indexing process has been stopped by WP-CLI and your (ElasticPress.io||Elasticsearch) index could be missing content. To restart indexing, please click the Start button or use WP-CLI commands to perform the reindex. Please note that search results could be incorrect or incomplete until the reindex finishes." |
Description of the Change
This PR updates the Sync Page to show a message when an indexing is stopped by the WP-CLI command (
wp elasticpress stop-indexing
)Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
#2489
Changelog Entry