Second pass at Fix a rare edge-case bug where invalid values in tax_query terms resulted in a broken query by passing terms array via array_filter to remove false and null

[rinatkhaziev]

Description of the Change

#2576 contained an error where filtered array wasn't passed through array_values to reset the keys, leading to json_encode treating it as object rather than array, this again resulted in a broken query.

This PR addresses that and includes the tests.

Alternate Designs

Possible Drawbacks

Verification Process

See the original PR for steps to test.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Changelog Entry

Credits

Props @

[rinatkhaziev]

The failing test seems to be

1) ElasticPressTest\TestPost::testStickyPostsExcludedOnNotHome
Failed asserting that 'Sticky post' is not equal to 'Sticky post'.