Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow truthy values for enabling weighting #2673

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR is an alternative version of #2597, changing the approach a little bit and also adding unit tests.

Note that this bug only happens when only fields using 'enabled' => 1 are added, i.e., if default fields are enabled, it will still work properly.

Changelog Entry

Fixed: Truthy values for the 'enabled' field's attribute while using the ep_weighting_configuration_for_search filter.

Credits

Props @felipeelia and @moritzlang

@felipeelia felipeelia merged commit 00d6976 into develop Mar 28, 2022
@felipeelia felipeelia deleted the fix/issue-2482 branch March 28, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants