Allow truthy values for enabling weighting #2673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is an alternative version of #2597, changing the approach a little bit and also adding unit tests.
Note that this bug only happens when only fields using
'enabled' => 1
are added, i.e., if default fields are enabled, it will still work properly.Changelog Entry
Fixed: Truthy values for the
'enabled'
field's attribute while using theep_weighting_configuration_for_search
filter.Credits
Props @felipeelia and @moritzlang